search

codeforcauseorg / edu-client

Product focuses on 100% education as well as upskilling developing countries and rural areas.
https://educlient.codeforcause.org/
MIT License
130 stars 149 forks source link

React Swipeable Routes also has Course Details Page #96

Closed rizwan2000rm closed 3 years ago

rizwan2000rm commented 3 years ago

Describe the bug

I think React Swipeable Routes should not be wrapped around the Course Detail Page. Once visiting the /course/:id route one can swipe beyond the Profile Page.

To Reproduce

Steps to reproduce the behavior:

  1. Visit /course/:id route once
  2. Now you can swipe backwards and forwards from this page (i.e. swipe right from Profile Page to go to Course Detail page and vice versa)

Expected behavior

Course Details page should not be swipeable.

Environment (please complete the following information):

Additional context

This only happens once the Course Detail page render is triggered by going to the route. You cannot swipe to it unless you go to /course/:id route

ADRE9 commented 3 years ago

@Abhishek-kumar09 can I work on it? It needs a small fix.

Abhishek-kumar09 commented 3 years ago

Thanks @rizwan2000rm for opening this issue.

ADRE9 commented 3 years ago

@Abhishek-kumar09 I have made the PR.