Set Croatian as default language for CfC

[schlos]

Info from Chris regarding setting default language in https://github.com/codeforcroatia/codeforcroatia.org/blob/emergence/vfs-site/master/php-classes/Emergence/Locale.php#L11:

• changing those values is what the php-config tree is for

• create a file under a path matching the class name in there and you can change any of the classes static public properties as part of when it gets loaded

[schlos]

TBC: https://github.com/codeforcroatia/codeforcroatia.org/blob/master/php-config/Emergence/Locale.config.php via https://github.com/codeforcroatia/codeforcroatia.org/commit/4c9c2c2565d06d05fb6f71cb01c1dfc3a23f8e3a

[schlos]

It still loads site with a Croatian as default language: http://cfc-staging-v3.poplar.phl.io/

[schlos]

Auto-language selection works with

Accept-Language header:

• with my default EN headers -> site language is EN
• with modded headers to hr_HR,hr -> site language is HR
• with modded headers to null -> site language falls back to default (EN) --> Fail, expected is to fall back to HR
• with modded headers set to de_DE,de --> site will be displayed in en_US --> Fail, expected is to fall back to HR (default value in 4c9c2c2)

Mod headers with ModHeader: https://chrome.google.com/webstore/detail/modheader/idgpnmonknjnojddfkpgkljpfnnfcklj/

[schlos]

I would probably make new PR upstream to change https://github.com/codeforcroatia/codeforcroatia.org/blob/emergence/vfs-site/master/php-classes/Emergence/Locale.php so that we have initial setting with primary language and if it's set, then page will always initially load in predefined primary language.

[schlos]

There is bug because it will fall back always to en_US rather than configured language in php-config: https://github.com/codeforcroatia/codeforcroatia.org/blob/master/php-config/Emergence/Locale.config.php It seems this configuration is not overriding default set value in Locale.php.

i.e. Accept-Language header is set to de_DE,de --> site will be displayed in en_US

New primary language feature will be tracked via separate issue https://github.com/codeforcroatia/codeforcroatia.org/issues/53

[schlos]

Check what is my Request headers (Accept-Language): https://manytools.org/http-html-text/http-request-headers/

Before test:

• always clear language cookie

Device 1: Request headers

• Accept-Language | hr,en-GB;q=0.9,en-US;q=0.8,en;q=0.7 Auto-selected site language:
• http://cfc-staging-v3.poplar.phl.io/ - English (US)

Device 2: Request headers

• Accept-Language | hr-HR,hr,en-US,en Auto-selected site language:
• http://cfc-staging-v3.poplar.phl.io/ - English (US)

Device 3: Request headers

• Accept-Language | fr-FE,fr,en-US,en Auto-selected site language:
• http://cfc-staging-v3.poplar.phl.io/ - English (US)

[schlos]

Try with: https://github.com/codeforcroatia/codeforcroatia.org/commit/6d2751bb7feeb3b064916fb98d61ae2951d0d6e2

[schlos]

Done with https://github.com/codeforcroatia/codeforcroatia.org/commit/ac631cc13715ca31f45b06ab7f799029dbd5e72d and https://github.com/codeforcroatia/codeforcroatia.org/commit/4c9c2c2565d06d05fb6f71cb01c1dfc3a23f8e3a