codeforcroatia / imamopravoznati

Provide a Freedom of Information request system for your jurisdiction
http://alaveteli.org
Other
3 stars 1 forks source link

Investigate postcode detection #95

Open schlos opened 3 years ago

schlos commented 3 years ago

Expected Behavior

Transifex revealed: "Your request contains a postcode. Unless it directly relates to the subject of your request, please remove any address as it will appear publicly on the Internet."

How it's detected? https://drive.google.com/file/d/1otsV1VmUg38qtrDoo_23SdoKLkBsGZLH/view?usp=sharing Screenshot: (Code for Croatia access only)

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Context

Your Environment

schlos commented 3 years ago

https://github.com/mysociety/alaveteli/search?q=contains_postcode

PR: https://github.com/mysociety/alaveteli/commit/bc2267d366f627ab7208273b2ece2af1b847c086

More details: https://github.com/mysociety/alaveteli/issues/3515#issuecomment-253090232 https://github.com/mysociety/commonlib/blob/b9a38c92e59338548961cb523dd746092db09b25/rblib/validate.rb#L153