Menu cannot be closed if opened on mobile

[schlos]

Describe the bug

Mobile menu was broken when fixing desktop menu position (see #103). Menu cannot be closed if opened on mobile.

To Reproduce Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior

Menu should be displayed below menu hamburger icon. Menu should be possible to close by clicking on hamburger icon. By fixing this we should not revert fix made for desktop: #103.

Screenshots

Desktop (please complete the following information):

• OS: [e.g. Windows]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context

[schlos]

How to contribute? Read our contribution guidelines at https://codeforcroatia.org/popravito-contribution-guidelines.

[znmustic]

Preuzela i ovo :)

[schlos]

Test report:

• before pull request #192

• after pull request #192

Menu icon is now moved outside of the screen, although issue is fixed and menu button is visible when menu is opened, and can be closed by clicking the menu icon again.

@znmustic, fix for this would be to move menu position back to the visible part of the screen (top right part of the mobile screen). How does that sound?

An improvement, if possible would be to show "X" instead of the menu hamburger icon for the menu close action. I.e. X button would be as big as hamburger icon. Let us know if you need a Figma design for this, and we will ask designer to take a look.

[znmustic]

I did what you asked, I think that now is all good. Just made a pull for fix https://github.com/codeforcroatia/popravi.to/pull/194 so you can check it and tell if needed anything more.

[schlos]

Fixed via #194

Screenshots after the fix: