codeforcroatia / popravi.to

This is popular map-based reporting platform FixMyStreet for Croatia named "Popravi.to"
http://popravi.to
Other
9 stars 7 forks source link

Missing back buttons to the Report problem screens on mobile (🅼3) #97

Open schlos opened 3 years ago

schlos commented 3 years ago

Describe the bug

Add missing back buttons to the Report problem flow.

Known bug, feedback from Silvija with PR 93:

Back gumb na prijavi problema ne radi pa sam ga privremeno uklonila, ne znam postoji li u base kodu verzije koju imamo jer ga nisam mogla naći

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Screenshots

Expected: Comparison back button behaviour in 'fixmystreet' cobrand (master branch, new sw, with multistep):

Screenshot_20210815-215653_Brave.jpg

Screenshot_20210815-215730_Brave.jpg

Screenshot_20210815-215750_Brave.jpg

Comparison back button behavior in 'tlf' cobrand (v3.1, same as our develop branch) - has back button on some screens:

Screenshot_20210815-215902_Opera Touch.jpg

Back link is actually same as go back and edit problem:

Screenshot_20210815-220049_Opera Touch.jpg

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context

Back functionality in base cobrand: https://gist.github.com/schlos/d1d3bd175dcee17a94ee5dd04726a716#file-fms-base-report-new-fill_in_details-html-L45

schlos commented 3 years ago

Partially fixed with the latest PR:

photo_2021-08-23 22 51 23

photo_2021-08-23 22 51 28

photo_2021-08-23 22 51 30

schlos commented 2 years ago

How to contribute? Read our contribution guidelines at https://codeforcroatia.org/popravito-contribution-guidelines.