search

codefordallas / codefordallas.github.io

Code for Dallas Website
7 stars 10 forks source link

rough integration + prep for volunteer meeting #42

Closed ProsperousHeart closed 1 year ago

ProsperousHeart commented 1 year ago

In an attempt to have a smoother volunteer meeting to show possible options for converting HTML & CSS to react, I took a stab at #39 ... it took a lot longer than anticipated (about 1 business day) due to how original components were created but attempted to document the process.

This PR is to merge into the branch so it is available for others to work on afterwards.

Known bugs:

This merge incorporates:

They are not finalized - simply brought into a React app for further updates

ProsperousHeart commented 1 year ago

@RobinHerzig @ShermanMarshall - this is a PR request into a branch that is NOT main.

image

Here's what I did:

  1. I created a copy of wireframe2023
  2. I locked wireframe2023 since it was only to be used as a way to get some of the components base infrastructure created with HTML & CSS (collaboratively with volunteers)
  3. I integrated wireframe components and wrote the steps while fixing some bugs along the way (there are still some, but can now be more easily addressed by multiple people)
  4. I am requesting merging my changes into the new issue39-reactapp

For our volunteer meeting, I'm going to take this branch and walk them through the process. But this PR is to get it into the code so others can work on the rest.

Since this is going into a new branch that was created, please go ahead and approve then merge this request.

ProsperousHeart commented 1 year ago

Looks good to me. I'm curious about App.js though, there's a lot of commented code. It looks like a lot of it is for scrolling animations? I'm guessing it'll either be implemented or removed in the future.

Yea - this was stuff I was working on to make the nav bar work in my other site.

I'll create an issue to clean this up - at least for the code I know can be removed. (Minus the create-react-app code ... at least until we have the volunteer group meeting to show where it once was)

Thanks @RobinHerzig

UPDATE: See #45