search

codefordayton / grocer

Find grocery stores, farmers markets, ethnic food stores, and CSA's in the Dayton region
Other
0 stars 3 forks source link

Display store details in the sidebar #9

Open dwcaraway opened 10 years ago

dwcaraway commented 10 years ago

Display store details in the sidebar.

dlangh commented 10 years ago

I removed the sidebar button, we could do one of 2 things to complete this task:

  1. Add sidebar button back to top menu.
  2. Add More-Info link within the popup that could trigger opening up the sidebar with all the remaining details.
dwcaraway commented 10 years ago

I like option 2 - the more-info link that triggers the sidebar. Anyone else?

raudabaugh commented 10 years ago

Yeah, I prefer option 2 as well. 

On Tue, Apr 8, 2014 at 3:07 PM, Dave Caraway notifications@github.com="mailto:notifications@github.com"> wrote:

I like option 2 - the more-info link that triggers the sidebar. Anyone else?

— Reply to this email directly or view it on GitHub.

dlangh commented 10 years ago

I added more info... and it opens the sidebar. Still need to have sidebar content show appropriate info. Need to have the popup close when they click more info, at least on mobile as the popup remains over top of the sidebar. I will also look into possibility of changing z-index for sidebar and popup, maybe if the sidebar has higher z-index it will show on top of popup in mobile, which might work, if not I'll close popup before opening sidebar.

dlangh commented 10 years ago

This work is complete, only thing I'm not sure about is when your viewing via desktop and you click on a maker, then "More Info..." which opens the sidebar, I am leaving the popup window open. For mobile I had to close it, but for desktop I am leaving it open, if anyone has thoughts on that speak up, otherwise this is complete

raudabaugh commented 10 years ago

Nice work! Just a thought: maybe we should have the sidebar update when clicking on a marker instead of "More Info?"

On Mon, Apr 14, 2014 at 2:52 PM, dlangh notifications@github.com wrote:

This work is complete, only thing I'm not sure about is when your viewing via desktop and you click on a maker, then "More Info..." which opens the sidebar, I am leaving the popup window open. For mobile I had to close it, but for desktop I am leaving it open, if anyone has thoughts on that speak up, otherwise this is complete

— Reply to this email directly or view it on GitHubhttps://github.com/codefordayton/grocer/issues/9#issuecomment-40403754 .

dlangh commented 10 years ago

Ok, if I understand correctly, you want it to update the content IF the sidebar is already open and someone clicks on another marker. That makes sense, I can do that

On Mon, Apr 14, 2014 at 4:20 PM, Sam Raudabaugh notifications@github.comwrote:

Nice work! Just a thought: maybe we should have the sidebar update when clicking on a marker instead of "More Info?"

On Mon, Apr 14, 2014 at 2:52 PM, dlangh notifications@github.com wrote:

This work is complete, only thing I'm not sure about is when your viewing via desktop and you click on a maker, then "More Info..." which opens the sidebar, I am leaving the popup window open. For mobile I had to close it, but for desktop I am leaving it open, if anyone has thoughts on that speak up, otherwise this is complete

— Reply to this email directly or view it on GitHub< https://github.com/codefordayton/grocer/issues/9#issuecomment-40403754> .

— Reply to this email directly or view it on GitHubhttps://github.com/codefordayton/grocer/issues/9#issuecomment-40413034 .

dlangh commented 10 years ago

I think I might not have fully understood the desire for sidebar vs more info... Dave mentioned something similar in an email. Do you mean that we should dispense with the popup altogether and simply open the sidebar when a user clicks on a pin? If so I would agree that would work better I think.

raudabaugh commented 10 years ago

I agree. The popup seems redundant.

dwcaraway commented 10 years ago

I like having the popup and sidebar. Popups are great when you're just clicking around the map trying to see what's there (in a hurry or don't care about details). The sidebar is a great way to discover the details. I'm fine with the design as-is. only suggestion would be to hide the "more info" link when sidebar is displayed.

dwcaraway commented 10 years ago

@dlangh fantastic job, btw