search

codefordenver / encorelink

Connecting musician volunteers with healthcare centers
https://encorelink.herokuapp.com/
ISC License
20 stars 14 forks source link

248 delete event #336

Closed nlkluth closed 7 years ago

nlkluth commented 7 years ago

This PR closes #248

What does this PR do?

Delete an event!

@wdoug I couldn't figure out how to make a delete not update the API state to STALE which caused a fetch to happen in gimmieData's componentWillReceiveProps. This would throw errors since re-fetching the event at /:id is no longer there when deleted. I removed delete from urlDataReducer, but I assume there is a better way :)

How does this PR make you feel? :link:

wdoug commented 7 years ago

@nlkluth interesting, I'll have to play around with this a bit.

vijoditz-agustin commented 7 years ago

looks good; I spent some time trying to simulate the delete request for another event and I wasn't able to - I'll create a task in waffle for the future

vijoditz-agustin commented 7 years ago

:shipit: