codefordenver / encorelink

Connecting musician volunteers with healthcare centers
https://encorelink.herokuapp.com/
ISC License
20 stars 14 forks source link

367 netlify cra frontend #377

Closed nlkluth closed 6 years ago

nlkluth commented 6 years ago

This PR closes #367

What does this PR do?

Kicking off this PR though there are still a few things left todo:

How does this PR make you feel? :link:

wdoug commented 6 years ago

Nice gif @nlkluth

wdoug commented 6 years ago

I am getting an error when trying to run react storybook:

ERROR in ./src/scss/app.scss
Module parse failed: Unexpected character '@' (1:0)
You may need an appropriate loader to handle this file type.
| @import './vendors/foundation/foundation';
| @include foundation-everything(true);
jsullivan5 commented 6 years ago

@wdoug I'm not too familiar with this loopback framework, but it handles a lot of the database endpoints for you. Under the hood it must be routing the database calls through /api. The dev port is 3000 and 54321 could be postgres. The host looks like its set to a generic default. Not certain though. Documentation: https://loopback.io/doc/en/lb2/config.json.html

On Wed, Apr 4, 2018 at 8:57 PM, Will Douglas notifications@github.com wrote:

@wdoug commented on this pull request.

In server/config.json https://github.com/codefordenver/encorelink/pull/377#discussion_r179339544 :

@@ -1,7 +1,7 @@ { "restApiRoot": "/api", "host": "0.0.0.0",

  • "port": 3000,
  • "port": 54321,

@nlkluth https://github.com/nlkluth is this just arbitrary?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/codefordenver/encorelink/pull/377#pullrequestreview-109565042, or mute the thread https://github.com/notifications/unsubscribe-auth/AUU5JvuTchq7bFv9VyzIT0aQAg9GZS4Qks5tlYgfgaJpZM4Sn8Zs .

-- James Sullivan Web Developer (214) 621-0523 jamesfsullivan5@gmail.com Github https://github.com/jsullivan5 | Portfolio https://jsullivan5.github.io/ | LinkedIn https://www.linkedin.com/in/james-f-sullivan/