Open trex opened 4 years ago
@zacharyrose I pushed some changes to the invite-users
branch of the server last night. The inviteUserToGroupByEmail
and acceptGroupInvite
mutations were returning a boolean
rather than Group
, which did not match the GraphQL schema. They are both now returning the group related to the groupId
parameter passed in.
Can we add a required String parameter, message
, to the inviteUserToGroupByEmail
mutation, so that a message from the user extending the invitation is passed along in the email to the invited person to build trust in accepting the invite?
@zacharyrose I pushed changes to the invite-users
branch on hawthorn-server
to update the inviteUserToGroupByEmail
mutation interface to:
inviteUserToGroupByEmail(groupId: ID!, email: String!, customMessage: String!): Group!
These changes add a new table to the database for modeling the outstanding group invitations. You will need to run prisma deploy
from the command line to run the database migrations to add the table and generate an updated javascript prisma client.
@zacharyrose I finished up the backend changes for this issue, pushed to the invite-users
branch (https://github.com/codefordenver/hawthorn-server/pull/9).
I know we are holding on building more onto the frontend until design is ironed out and the atomic component architecture is in place. However, people have started signing up for accounts and I would like to add these features to the frontend ASAP so that we can have a meaningful user experience in the application. Can we add these components to the frontend now and refactor when the design and architecture is ironed out?
Hey Trevor, yes I will look at that tonight.
On Thu, Mar 12, 2020 at 11:48 PM trevor smith notifications@github.com wrote:
@zacharyrose https://github.com/zacharyrose I finished up the backend changes for this issue.
I know we are holding on building more onto the frontend until design is ironed out and the atomic component architecture is in place. However, people have started signing up for accounts and I would like to add these features to the frontend ASAP so that we can have a meaningful user experience in the application. Can we add these components to the frontend now and refactor when the design and architecture is ironed out?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/codefordenver/hawthorn-client/issues/36#issuecomment-598561590, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADM7Q42LQ7BFL24OAEM3KMDRHHCMJANCNFSM4KI6WUIA .
Frontend
Backend
Design