codecov-io
commented
5 years ago Codecov Report
Merging #300 into master will decrease coverage by
2.95%. The diff coverage is29.16%.
@@ Coverage Diff @@
## master #300 +/- ##
==========================================
- Coverage 43.17% 40.22% -2.96%
==========================================
Files 71 70 -1
Lines 799 803 +4
Branches 185 188 +3
==========================================
- Hits 345 323 -22
- Misses 447 477 +30
+ Partials 7 3 -4| Impacted Files | Coverage Δ | |
|---|---|---|
| src/authenticated/member/MemberProfile.tsx | 9.09% <ø> (ø) |
:arrow_up: |
| src/generated-models.tsx | 49.39% <ø> (-9.64%) |
:arrow_down: |
| src/authenticated/project/ProjectPage.tsx | 16.66% <16.66%> (-16.67%) |
:arrow_down: |
| src/authenticated/member/MemberProfilePage.tsx | 16.66% <16.66%> (+2.38%) |
:arrow_up: |
| src/authenticated/member/MyProfilePage.tsx | 14.28% <16.66%> (-8.8%) |
:arrow_down: |
| src/authenticated/project/ProjectEditPage.tsx | 4.54% <4.54%> (-5.46%) |
:arrow_down: |
| src/authenticated/member/MemberForm.tsx | 4.76% <4.76%> (ø) |
|
| src/authenticated/member/MemberProfileEditPage.tsx | 4.54% <5.88%> (-10.84%) |
:arrow_down: |
| src/authenticated/project/ProjectCreatePage.tsx | 65.21% <65.21%> (-1.45%) |
:arrow_down: |
| src/authenticated/project/ProjectForm.tsx | 73.68% <73.68%> (ø) |
|
| ... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 2d66990...b1dd190. Read the comment docs.
This PR closes #258
What does this PR do?
Investigates refactoring our form handling to use Formik
I know we had just said we were done with refactors for now, but I started playing around with Formik a bit and it was so easily incrementally adoptable from the custom setup I had hacked together.
Based on this initial spike work, I think we should move forward and update this everywhere.
How does this PR make you feel? :link: