search

codefordenver / partner-finder

Using an open dataset with registered colorado business to build a tool that manages outreach to potential CFD partners.
3 stars 14 forks source link

Update Parcel to version 2 #179

Open galbwe opened 3 years ago

galbwe commented 3 years ago

We are currently using parcel-bundler version 1, but version 2 was recently released in a different library called parcel.

oliviacarino commented 3 years ago

Hi @galbwe can you assign this issue to me? Thanks!

galbwe commented 3 years ago

Hey @oliviacarino. Sure!

galbwe commented 3 years ago

@oliviacarino are you still working on this issue?

oliviacarino commented 3 years ago

@galbwe I was not able to install and use docker/docker-compose on my machine to check if the app was running okay after updating to parcel. Sorry about that, I've unassigned myself

galbwe commented 3 years ago

Oh okay no worries.

galbwe commented 3 years ago

After looking into this a bit more, it seems like we are using multiple versions of material ui, and this causes dependency issues after upgrading parcel. After following this migration guide and running yarn dev, I get this error:

🚨 Build failed.

@parcel/core: Failed to resolve '@mui/icons-material/Instagram' from './src/components/LeadRow.js'

  /Users/wes/projects/partner-finder/frontend/src/components/LeadRow.js:9:27
     8 | import TwitterIcon from '@mui/icons-material/Twitter';
  >  9 | import InstagramIcon from '@mui/icons-material/Instagram';
  >    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    10 | import MailOutlineIcon from '@mui/icons-material/MailOutline';
    11 | import Avatar from '@material-ui/core/Avatar';

@parcel/resolver-default: Cannot find module @mui/icons-material
💡 Did you mean '@mui/material'?

Not sure how entailed fixing this will be.