search

codefordenver / partner-finder

Using an open dataset with registered colorado business to build a tool that manages outreach to potential CFD partners.
3 stars 14 forks source link

Remove python exceptions that can be sent in api responses #190

Closed galbwe closed 3 years ago

galbwe commented 3 years ago

There is at least one return statement in the backend that looks like this;

except SomeException e:
    return {"message": f"There was a problem: {e}"}, 422

CodeQL issues warnings here because it's bad practice to send language / framework specific details to a user.

Find other places where this is an issue. Update these return statements to not include the python exeption and instead use a message that gets a similar point across.

kaleeaswari commented 3 years ago

@galbwe can I get this assigned?