search

codefordurham / school-navigator

Navigate the Durham, NC public school system
https://durhamschoolnavigator.org
26 stars 16 forks source link

Open profile in new tab #354

Closed sarahsba closed 8 years ago

sarahsba commented 8 years ago

When you click on the "View school profile" link on the map page, it opens up the profile on the same tab so that you lose the map view. I think it'd be easier for users if the profile opened in a separate tab so that users can open multiple profiles at a single time to read. If we do that, we'd want the mini-profile to remain open I think. Right now if you hold control and click the "view school profile" link to open the profile in a new tab, the mini profile automatically closes and is no longer visible.

What do y'all think? Maybe you discussed this already at the meeting in which case you can ignore this. :)

alexlemann commented 8 years ago

Hi @sarahsba I think that we discussed this in: #295 and decided that the links within the site would be in the same tab but links out to other sites would be in a new tab. Do you agree?

That said.... the link to the school's own site within the profile links out in the same tab now which is inconsistent with how this is handled in the mini profile view.

sarahsba commented 8 years ago

@alexlemann, you're right, we did agree to that in @295. I don't follow the second part of your comment: "That said.... the link to the school's own site within the profile links out in the same tab now which is inconsistent with how this is handled in the mini profile view." Can you elaborate?

alexlemann commented 8 years ago

@sarahsba I was talking about the school website link in the At A Glance section of the profile opening in the same tab even though it links out to a different site. at-a-glance-link

lotusgraham commented 8 years ago

@sarahsba @alexlemann Below is a GIF of what these pages should behave like. I'll work on making this happen.

schoolnav-newtab

sarahsba commented 8 years ago

Got it, thanks. I agree with the approach y'all are working on. Looks great.

On Aug 13, 2016 1:34 PM, "Graham Whitley" notifications@github.com wrote:

@sarahsba https://github.com/sarahsba @alexlemann https://github.com/alexlemann Below is a GIF of what these pages should behave like. I'll work on making this happen.

[image: schoolnav-newtab] https://cloud.githubusercontent.com/assets/13974084/17644628/b0464576-6159-11e6-9a27-1437531c1ede.gif

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/codefordurham/school-navigator/issues/354#issuecomment-239632426, or mute the thread https://github.com/notifications/unsubscribe-auth/ALfAvkYpxU90DK37HJQeTDdQZVVKSTAiks5qfgAIgaJpZM4JMBNU .