search

codeforequity-at / botium-bindings

The Selenium for Chatbots
http://www.botium.at
MIT License
108 stars 33 forks source link

change to improve fbdirect functioning #87

Closed petuscov closed 6 years ago

petuscov commented 6 years ago

This solves bug described in issue 81, we can study enhancements to support regexps, to indicate places in sentences where bot response may vary without being incorrect (e.g weather of a city, the city name and the forecast could vary)

codeforequity-at commented 6 years ago

Got build output:

/home/rof/src/github.com/codeforequity-at/testmybot/src/helpers/jasmine.js 13:66 error Extra semicolon semi 16:30 error Trailing spaces not allowed no-trailing-spaces 17:14 error Missing space before => arrow-spacing 17:17 error Missing space after => arrow-spacing 18:32 error Missing space before => arrow-spacing 18:35 error Missing space after => arrow-spacing 19:13 error Expected space(s) after "if" keyword-spacing 19:20 error Missing space before opening brace space-before-blocks 20:24 error Extra semicolon semi 22:19 error Extra semicolon semi 23:13 error Extra semicolon semi

11 problems (11 errors, 0 warnings) 11 errors, 0 warnings potentially fixable with the --fix option.

please run "npm run build" before pushing to avoid such eslint errors. Some days ago I wrote a "contribution guide", but it's just a start ... https://github.com/codeforequity-at/testmybot/blob/master/CONTRIBUTING.md

codeforequity-at commented 6 years ago

by the way, i don't know if the Codeship output is visible to you as contributor ?

codeforequity-at commented 6 years ago

Regexps are supported - there is a capability named "SCRIPTING_MATCHING_MODE" (possible values: regexp, include, includeLowerCase, equals). by default, the "includeLowerCase" is used, but when switching to regexp, the bot response is treated as regular expression