search

codeforequity-at / botium-core

The Selenium for Chatbots - Bots Testing Bots
https://www.botium.ai
MIT License
230 stars 64 forks source link

Suggestion Chips / Link Out Suggestions Asserter #409

Closed ghost closed 4 years ago

ghost commented 5 years ago

Is your feature request related to a problem? Please describe. We haven't found a way to validate suggestion chips' presence in Google Assistant response without altering the Google Assistant connector.

Describe the solution you'd like We'd like to validate if Google Assistant's response has the specified suggestion chips and/or link out suggestion.

Describe alternatives you've considered Besides not validating suggestions at all, we don't really have alternatives.

Additional context Nothing else to add.

ghost commented 5 years ago

While investigating we were able to make our custom Suggestion asserter work by adding a suggestions property to the response queued by the Google Assistant connector but we're not 100% sure if that's the right way to do it.

Any suggestions on how to proceed?

codeforequity-at commented 5 years ago

The Google Assistant connector currently doesn't support anything else but plain text - it is in our backlog though. If you think you found a solution for your exact issue, we are happy to merge in any pull requests.

ghost commented 5 years ago

Thanks, I'll send a pull request your way when we'll have something solid.

codeforequity-at commented 4 years ago

Did you have any success yet on this ?

ghost commented 4 years ago

We haven't been able to work a lot on this but I've created a Pull Request with the related changes.

Once the connector exposes the required properties we'll then be able to make an asserter to check for suggestion chips / link out suggestions in botium-core.

codeforequity-at commented 4 years ago

As it is implemented now, it would allow to use the JSONPATH-asserter for doing this. But maybe it would be a good idea to map these suggestions to buttons - should be roughly the same as a quick link, I guess.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.