search

codeforgermany / click_that_hood

A game where users must identify a city's neighborhoods as fast as possible
http://click-that-hood.com
MIT License
452 stars 638 forks source link

Warning for mobile devices & reduced size of africa.geojson #162

Closed davidbauer closed 10 years ago

davidbauer commented 10 years ago
  1. Displays a warning message if site is accessed from a mobile device and doesn't execute the functions within main().
  2. africa.geojson file reduced from 1.3mb to 100kb. for some reason, borders for sudan and south sudan were ridiculously detailed.
mwichary commented 10 years ago

Can you split this into two? I have a number of issues with the mobile device warning, but that shouldn’t prevent the Africa optimization from getting in.

mwichary commented 10 years ago

Suggestions for the mobile warning:

  1. The text is a bit unfriendly. I think there should be a description of what the game is, why won’t it work on a small screen, and what specifically to do (use tablet or desktop)
  2. I think a good practice is defaulting to display: none for errors, and only showing them when something goes wrong (it’s the opposite here)
  3. The 500px constant present in both places, which is a maintenance issue. Since you already have the logic on the JS side, can we keep it there and remove from CSS? (That obviates point 2 above.)
  4. Why 500px? Shouldn’t it be a bit larger? (568px is the 4" iPhone’s larger axis)
  5. Please use [div] instead of [p] for consistency.
davidbauer commented 10 years ago

done. the mobile hack is really a dirty one, so I'm only sending the new geojson file.

2013/11/26 Marcin Wichary notifications@github.com

Issues with the mobile warning:

  1. The text is a bit unfriendly. I think there should be a description of what the game is, why won’t it work on a small screen, and what specifically to do (use tablet or desktop)
  2. I think a good practice is defaulting to display: none for errors, and only showing them when something goes wrong (it’s the opposite here)
  3. The 500px constant present in both places, which is a maintenance issue. Since you already have the logic on the JS side, can we keep it there and remove from CSS? (That obviates point 2 above.)
  4. Why 500px? Shouldn’t it be a bit larger? (568px is the 4" iPhone’s larger axis)

  5. Please use instead of

    for consistency.

— Reply to this email directly or view it on GitHubhttps://github.com/codeforamerica/click_that_hood/pull/162#issuecomment-29322978 .

David Bauer. Journalist+ davidbauer.ch | twitter.com/davidbauer | facebook.com/davidbauer

mwichary commented 10 years ago

A mobile warning is now in effect, thanks for starting the work on this!