search

codeforgermany / click_that_hood

A game where users must identify a city's neighborhoods as fast as possible
http://click-that-hood.com
MIT License
452 stars 638 forks source link

Problems with historic maps of Europe (1914, 1938) #196

Open rkh opened 10 years ago

rkh commented 10 years ago

A list of what still needs to be fixed:

1914 Ireland should be part of the UK Iceland should be part of Denmark Finland should be part of Russia Denmark/Germany border is wrong? Corsica should be part of France northern tip of Morrocco should be part of Spain? Cyprus should be part of UK Germany/France borders are imprecise? Romania/Russia borders are imprecise?

1938 Iceland should be part of Denmark Denmark/Germany border is wrong? Czech part of Czechoslovakia should not be part of Poland Slovakia should be named Czechoslovakia Carpathian Ruthenia should be part of Czechoslovakia and not Hungary Sudetenland annexation by Germany was in 1938. East Prussia should be part of Germany northern tip of Morrocco should be part of Spain? Cyprus should be part of UK Germany/France borders are imprecise? Romania/Russia borders are imprecise?

rkh commented 10 years ago

The Europe in 1914 map shows Ireland as a country. However, it was part of the United Kingdom of Great Britain and Ireland until 1922.

The same goes for Iceland, which did not become independent until 1944. This is also affects the 1938 map.

rkh commented 10 years ago

And Finland. Finland did not achieve independence from Russia until 1917.

mwichary commented 10 years ago

Thanks! That’s good to know. If anyone here is reading this and is willing to make the changes to GeoJSON files, please feel free to take this one.

rkh commented 10 years ago

And the border between Denmark and Germany is todays border, at the time it was further north.

rkh commented 10 years ago

Also, for some reason when I hover over Corsica, it's shown as part of the German Empire (should be France).

rkh commented 10 years ago

On the 1938 map, Czechoslovakia is shown as part of Poland. Should I open a separate issue for the 1938 map?

rkh commented 10 years ago

Or rather, the Czech part is shown as part of Poland and Slovakia as its own country. Both is incorrect.

rkh commented 10 years ago

East Prussia is shown as a country in 1938, but it was part of Germany.

rkh commented 10 years ago

In both 1914 and 1938, the northern tip of Morocco was part of Spain, not sure if that should be integrated.

rkh commented 10 years ago

Cyrpus did not achieve independence until 1959.

mwichary commented 10 years ago

Thanks so much for this. I just grabbed the maps from here: http://library.thinkquest.org/C006628/GIS.html

I hope someone reading this can make those modifications.

mwichary commented 10 years ago

“I just want to tell you that your Map of Europe 1938 is totally wrong, in the case of central european region, there are several mistakes about Czechoslovakia, which is absolutelly missing on the map (todays Czech rep. as a part of Poland ?! and Slovakia in this year as its own country?! ) Czechoslovakia in 1938, before German occupation, was an independent country, even little bit bigger then after the war- the most western part of nowadays Ukraine, so called Carpathian Ruthenia was a part of Czechoslovakia (on your map its part of Hungary?!). And in september 1938 Hitler annected the Sudetenland (parts of Czechoslovakia laying close to borders with Germany).”

mwichary commented 10 years ago

“Is there any way to get in touch with the author of the Europe 1914 map? I've spotted a couple of errors so far: Ireland appears as a separate country, but in 1914, Ireland was still part of the United Kingdom. Finland is listed as a separate country, but in 1914, Finland was still part of the Russian Empire.”

rkh commented 10 years ago

I tried to fix this manually, but the only usable editor I found (geojson.io) does not let you edit existing shapes, which is annoying both for editing the existing map and for creating a new one from scratch.

mwichary commented 10 years ago

I think QGIS could be an option, but it has a terrible UI.

ralfharing commented 10 years ago

Moving Corsica from Germany to France was simple enough, but an attempt at fixing N. Ireland and Ireland was tedious (and wrong). It would help if cartodb labeled the points so the user could tell which one was which.

rkh commented 10 years ago

Also note that most of the borders are very imprecise or tend to be nowadays borders (for instance, the border Germany/France and Romania/Russia).

mwichary commented 10 years ago

Note that @ralfharing started working on this and just moved Corsica under German Empire rule (from France) in 1914, as per https://github.com/codeforamerica/click_that_hood/pull/202

mwichary commented 10 years ago

Possibly better source for 1938: http://geocommons.com/users/spatialhistory/overlays?order=ascending&page=1&query=tag%3Aeurope

ralfharing commented 10 years ago

I'm not planning on making more changes for this, but thought I would condense all the above information into a list of what still needs to be fixed:

1914 Ireland should be part of the UK Iceland should be part of Denmark Finland should be part of Russia Denmark/Germany border is wrong? Corsica should be part of France northern tip of Morrocco should be part of Spain? Cyprus should be part of UK Germany/France borders are imprecise? Romania/Russia borders are imprecise?

1938 Iceland should be part of Denmark Denmark/Germany border is wrong? Czech part of Czechoslovakia should not be part of Poland Slovakia should be named Czechoslovakia Carpathian Ruthenia should be part of Czechoslovakia and not Hungary Sudetenland annexation by Germany was in 1938. East Prussia should be part of Germany northern tip of Morrocco should be part of Spain? Cyprus should be part of UK Germany/France borders are imprecise? Romania/Russia borders are imprecise?

mwichary commented 10 years ago

Thanks, @ralfharing! This is very useful. I had no idea these maps were so buggy.

ralfharing commented 10 years ago

Those are the easy ones done. The rest require combining contiguous borders or shifting existing points to new locations and I leave those for others who can manipulate the data more easily.

ralfharing commented 10 years ago

Just fyi, there are still other changes for the Europe historical maps, but they require actual combination/elimination/shifting of some borders (the ones left without strikethroughs above). That's beyond how deep I want to get into the geojson files. Don't know if you want to open a clean separate issue for that or reopen this one?

mwichary commented 10 years ago

Oh, yeah, that was automatically closed. I’m reopening it, and I moved a list of things to do that you were kind enough to update to the very top.

mwichary commented 10 years ago

A list from an email, not yet integrated with the master list above:

In "Europe, 1914 countries" map there are #3 great mistakes. First: in 1914 Irealnd was not a Nation, The first indipendence started in

  1. Ireland and Great Britain was both “United Kingdom” Second, Iceland was not a Nation: it was “Denmark”. It become indipendent during WWII. Third, Finland become indipendent in 1917. In 1914 it was “Russian Empire”.

In "Europe, countries" (today), Ireland is signed as the whole island. There is Northern Ireland (UK)...

In "Rurope 1939" Czech epublik (Česká republika) was OR indipendent, OR united with the Slovakia. It depends by the month of 1938... Because the separation from Slovakia has been for a few time, if I were you, I keep Czech united with Slovakia. Hovever, it is NOT a part of Poland. Iceland, as in 1914, was Demark East Prussia, was Germany. Austria was indipendent in Jan 1938. In March become part of Germany. It can remain as it is.