search

codeforgermany / click_that_hood

A game where users must identify a city's neighborhoods as fast as possible
http://click-that-hood.com
MIT License
449 stars 638 forks source link

Esztergom and Canberra not in US - fixes #209 #213

Closed ralfharing closed 10 years ago

mwichary commented 10 years ago

That certainly fixes it, but it is a “lossy” fix. I think we can have the cake and eat it, too—those states should still appear in the sidebar, but the locations should not be duplicated in the navigation menu at the bottom.

On Wednesday, December 4, 2013, ralfharing wrote:

You can merge this Pull Request by running

git pull https://github.com/ralfharing/click_that_hood master

Or view, comment on, or merge it at:

https://github.com/codeforamerica/click_that_hood/pull/213 Commit Summary

  • Esztergom and Canberra not in US - fixes #209

File Changes

  • M public/data/canberra.metadata.jsonhttps://github.com/codeforamerica/click_that_hood/pull/213/files#diff-0(1)
  • M public/data/esztergom.metadata.jsonhttps://github.com/codeforamerica/click_that_hood/pull/213/files#diff-1(1)

Patch Links:

ralfharing commented 10 years ago

Oooh, I didn't even see that the states were used on the left sidebar.

mwichary commented 10 years ago

:·)

mwichary commented 10 years ago

Giving up so soon? :·)

ralfharing commented 10 years ago

I wasn't sure what the protocol was, re: creating a new pull request vs. changing and resubmitting this one?

mwichary commented 10 years ago

Whatever's easier!

On Wednesday, December 4, 2013, ralfharing wrote:

I wasn't sure what the protocol was, re: creating a new pull request vs. changing and resubmitting this one?

— Reply to this email directly or view it on GitHubhttps://github.com/codeforamerica/click_that_hood/pull/213#issuecomment-29863205 .