codeforgermany / click_that_hood

A game where users must identify a city's neighborhoods as fast as possible
http://click-that-hood.com
MIT License
449 stars 638 forks source link

Incorrect Chinese character toggle for China map #226

Closed selkieupsilon closed 10 years ago

selkieupsilon commented 10 years ago

For the china map http://click-that-hood.com/?city=china

There are two Chinese character sets, simplified and traditional.

The current list of province names are in simplified Chinese characters. However, the toggle text in the lower left of the map says that it is in traditional Chinese (繁体字). This is therefore incorrect.

The correct toggle text should say 简体字 (simplified Chinese).

I am happy to help add traditional Chinese characters to the current list of provinces, however I am unsure how to do this for the geojson files. If you can point me to where/how the list of English names for the provinces are kept currently I might be able to adapt that (unless you are using the filenames...)

Alternatively I can supply you with a list of traditional Chinese character province names, if that is easier than walking me through the editing process.

mwichary commented 10 years ago

Hey, sorry about that – it’s totally my fault.

If you could supply a list of traditional Chinese character province names in this order, I could plug it straight away: Heilongjian Xinjiang Shanxi Sichuan Tibet Shandong Henan Jiangsu Anhui Hubei Zhejiang Qinghai Gansu Shaanxi Inner Mongolia Chongqing Hebei Ningxia Jiangxi Hunan Yunnan Guizhou Fujian Guangxi Guangdong Hainan Jilin Liaoning Tianjin Shanghai Beijing Hong Kong Macau Taiwan

selkieupsilon commented 10 years ago

黑龍江 Heilongjian 新疆 Xinjiang 山西 Shanxi 四川 Sichuan 西藏 Tibet 山東 Shandong 河南 Henan 江蘇 Jiangsu 安徽 Anhui 湖北 Hubei 浙江 Zhejiang 青海 Qinghai 甘肅 Gansu 陝西 Shaanxi 內蒙古 Inner Mongolia 重慶 Chongqing 河北 Hebei 寧夏 Ningxia 江西 Jiangxi 湖南 Hunan 雲南 Yunnan 貴州 Guizhou 福建 Fujian 廣西 Guangxi 廣東 Guangdong 海南 Hainan 吉林 Jilin 遼寧 Liaoning 天津 Tianjin 上海 Shanghai 北京 Beijing 香港 Hong Kong 澳門 Macau 台灣 Taiwan

selkieupsilon commented 10 years ago

took off the English names

黑龍江 新疆 山西 四川 西藏 山東 河南 江蘇 安徽 湖北 浙江 青海 甘肅 陝西 內蒙古 重慶 河北 寧夏 江西 湖南 雲南 貴州 福建 廣西 廣東 海南 吉林 遼寧 天津 上海 北京 香港 澳門 台灣

mwichary commented 10 years ago

Sweet. How does it look now? http://click-that-hood.com/?location=china

selkieupsilon commented 10 years ago

Awesome! I forgot to mention, the traditional Chinese form of the characters for "traditional Chinese" should actually be 繁體字 rather than 繁体字 (the middle character has a more complicated form in traditional Chinese).

mwichary commented 10 years ago

Fixed!