codeforgermany / click_that_hood

A game where users must identify a city's neighborhoods as fast as possible
http://click-that-hood.com
MIT License
449 stars 638 forks source link

Adding City of Sydney #264

Closed nefshja closed 9 years ago

mwichary commented 9 years ago

Thanks for doing this – but do you know why do Mascot, Eastlakes, Kensington, and Darling Point have such weird shapes…?

e.g. image

nefshja commented 9 years ago

My guess is that the weird shapes are the segments of those neighbourhoods which are included in the City of Sydney's LGA boundary.

On Fri, Feb 27, 2015 at 1:49 PM, Marcin Wichary notifications@github.com wrote:

Thanks for doing this – but do you know why do Mascot, Eastlakes, Kensington, and Darling Point have such weird shapes…?

e.g. [image: image] https://cloud.githubusercontent.com/assets/2061609/6406629/251a9e4a-bde8-11e4-8bae-cd83c16ae9ff.png

— Reply to this email directly or view it on GitHub https://github.com/codeforamerica/click_that_hood/pull/264#issuecomment-76321836 .

techieshark commented 9 years ago

Ah, right, hmm... @mwichary, to produce this we clipped a countrywide suburbs (neighborhoods) shapefile by the boundary for the city of Sydney, so the clipping process may have resulted in fragments (some suburbs/neighborhoods are partly in Sydney and partly outside it).

techieshark commented 9 years ago

OK looking at it more in QGIS... it appears that Kensington has just a sliver of overlap with the City of Sydney (see the dark section on the borders in the image below). We should just remove that element from the geojson file.

Also note in this image that Kensington & City of Sydney fills are set to transparent so you'd be able to see if a larger section overlaps, which isn't the case.

tmp kensington-overlap

techieshark commented 9 years ago

Ah, and yes I checked the other suburbs mentioned. Same problem, as illustrated here (the only shapes with borders are the sliver polygons formed by the intersection of the suburbs and Sydney.

barely-intersecting-suburbs-with-sydney

For the benefit of others and my future memory, I just filtered out the my 'suburbs near sydney' shapefile with the following query:

"SSC_NAME" = 'Kensington (NSW)' OR "SSC_NAME" = 'Mascot' OR "SSC_NAME" = 'Eastlakes' OR "SSC_NAME" = 'Darling Point'

techieshark commented 9 years ago

One last one...

I clipped the suburbs file by Sydney's boundary, then manually selected each polygon which was large enough to click. That gave me what appeared to be everything but then I took the inverse of that selection using the attribute table (resulting in a selection of suburbs too small to click -- sliver polygons). I saved those slivers as a new shapefile and modified the map so only those had a black border and all other suburbs were just fill + white border (and Sydney has no border color).

You can see the sliver polygons as black lines, and I've then added in all suburbs and selected the ones that created those slivers.

The named suburbs should be all the ones that need to be removed from the dataset.

all-sydney-sliver-suburbs

mwichary commented 9 years ago

I don’t know if you meant to send an updated file, but I just removed the four offending neighbourhoods and pushed it live. http://click-that-hood.com/sydney

Please send any further changes if you see them. :·)

Thank you!!!

techieshark commented 9 years ago

Awesome, thanks @mwichary!

nefshja commented 9 years ago

Yeah awesome stuff! Thanks!

On Sun, Mar 1, 2015 at 10:17 PM, Peter W notifications@github.com wrote:

Awesome, thanks @mwichary https://github.com/mwichary!

— Reply to this email directly or view it on GitHub https://github.com/codeforamerica/click_that_hood/pull/264#issuecomment-76592540 .