codeforgso / GoVote

Local voter registration and election candidate application.

http://govotegso.org/

GNU General Public License v3.0

24 stars 46 forks source link

Create config.js file #123

Closed SchaeStewart closed 4 years ago

SchaeStewart commented 5 years ago

This is a:

[ ] bug
[x] enhancement
[ ] feature-discussion

Enhancement

Description

Create a config file for storing city and county specific variables. Start with the following items: city, city name abbreviated, county, app title (GoVoteGSO).

Implementation

Create a config.js file in the ./src directory.
Export the variables mentioned above. Use UPPER_SNAKE_CASE since these are "global" variables.

SchaeStewart commented 5 years ago

In the long run it may be better to move this to a .env file, but for now this is the quickest and simplest solution so we'll use it.

joshhazelhurst123 commented 5 years ago

hi @SchaeStewart I would like to create the config.js file. It sounds like creating a config.js file and declaring variables. Shall I create a pull request for this. Thanks. Example below. var CITY; var CITY_NAME_ABBREVIATED; var COUNTRY; var APP_TITLE;

SchaeStewart commented 5 years ago

@joshhazelhurst123 Correct. Just use const instead of var and use export keyword to export the variables.

If you have any other questions, just ask me here, or you can ping me on slack

joshhazelhurst123 commented 5 years ago

Thanks @SchaeStewart I have created a pull request for this #132

zenlex commented 4 years ago

Looks like this was closed and merged....