codeforgso / GoVote

Local voter registration and election candidate application.

http://govotegso.org/

GNU General Public License v3.0

24 stars 46 forks source link

Configure docker-compose.yml to use .env file #126

Closed SchaeStewart closed 5 years ago

SchaeStewart commented 5 years ago

This is a:

[ ] bug
[x] enhancement
[ ] feature-discussion

Enhancement

Description

Move the environment variables in the docker-compose.yml file to a .env file.
See docker-compose env docs: https://docs.docker.com/compose/environment-variables/

Implementation

Move the environment variables that are hard coded in the docker-compose.yml file.
Create a sample.env file that has the same keys as the .env file. Check this into the repo.
Add .env to .gitignore
Update README with instructions on copying sample.env to .env.

priyanka-ravi commented 5 years ago

@SchaeStewart I'll do this for you guys real quick! :)

SchaeStewart commented 5 years ago

Awesome thanks!

If you have questions ping me on slack

https://bit.ly/cfgso-slack

Schaffer

On Thu, Feb 14, 2019, 1:34 PM Priyanka Ravi <notifications@github.com wrote:

@SchaeStewart https://github.com/SchaeStewart I'll do this for you guys real quick! :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/codeforgso/GoVote/issues/126#issuecomment-463739834, or mute the thread https://github.com/notifications/unsubscribe-auth/AI9jTMJdkdI4J2cLmzNrDUZG0bDbDBY0ks5vNaxLgaJpZM4agP6q .