#92 Map on Where and When page

[remrobem]

92 added map component to the When and Where page with markers for the polling place and voter residence

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

• [ ] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes.
• [ ] All new and existing tests passed.

[remrobem]

Ok – I’ll take a look at those changes.

From: Schaffer Stewart notifications@github.com Reply-To: codeforgso/GoVote reply@reply.github.com Date: Friday, March 1, 2019 at 20:59 To: codeforgso/GoVote GoVote@noreply.github.com Cc: Rob Martin rob.martin.5758@gmail.com, Author author@noreply.github.com Subject: Re: [codeforgso/GoVote] #92 Map on Where and When page (#131)

@SchaeStewart requested changes on this pull request.

Everything looks pretty good so far. Just a couple a little changes that would be nice before I merge it.

Also can you mention the name of the API key variable in the CONTRIBUTING.md?

Thanks, Schaffer

---

In src/components/pages/WhereAndWhen.jsxhttps://github.com/codeforgso/GoVote/pull/131#discussion_r261807395:

• {!isLoading && Object.keys(pollingPlace).length > 0 ? (

• Polling Place Name: {pollingPlace.name}

• Polling Place Address:

• <a

• target="_blank"

• href={this._createVoterPrecintMapsLink(pollingPlace.address)}

• title="View on Google Maps"

• {pollingPlace.address}

We should hide this ListGroupItem when there is no API key present

---

In src/components/pages/WhereAndWhen.jsxhttps://github.com/codeforgso/GoVote/pull/131#discussion_r261807473:

   return;

 }

 const precinctDesc = voter.precinct_desc;

• const url = http://gis.co.guilford.nc.us/arcgis/rest/services/Elections/Elections/MapServer/0/query?where=UPPER(PRECINCT)%20like%20%27%25${precinctDesc}%25%27&outFields=*&outSR=4326&f=json;

• // const url = http://gis.co.guilford.nc.us/arcgis/rest/services/Elections/Elections/MapServer/0/query?where=UPPER(PRECINCT)%20like%20%27%25${precinctDesc}%25%27&outFields=*&outSR=4326&f=json;

Go a head and delete this old url

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/codeforgso/GoVote/pull/131#pullrequestreview-209846183, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKgtCpElW5y5Gr9Avyr-MWEI5kYHcT6Aks5vSdrkgaJpZM4bZp-e.

[SchaeStewart]

@remrobem Looks good. I'm going to merge it now.