codeforgso / GoVote

Local voter registration and election candidate application.
http://govotegso.org/
GNU General Public License v3.0
24 stars 46 forks source link

Run postgres in container #230

Closed nathansgithub closed 2 years ago

nathansgithub commented 2 years ago

Description

I updated the instructions for running locally and added commands in package.json according to issue #229.

Related Issue

229

Motivation and Context

It reduces the friction for new contributors. Since Docker Compose is already a project dependency, it makes sense to run Postgres there instead of making contributors setup their own database.

How Has This Been Tested?

I removed all existing Docker containers I had running and walked through the updated instructions in CONTRIBUTING.md.

Checklist:

nathansgithub commented 2 years ago

Ok, they are squashed!

nathansgithub commented 2 years ago

@tcaddy That makes sense. I added a named volume and also removed the specified Postgres version so it will use the latest version.

nathansgithub commented 2 years ago

@tcaddy I went ahead and squashed that into the other commit too. Let me know if that looks good. Thanks for reviewing this!