codeforgso / GoVote

Local voter registration and election candidate application.
http://govotegso.org/
GNU General Public License v3.0
24 stars 46 forks source link

Errors and Alerts persisting in Voter Lookup Modal #50

Closed BlakeGuilloud closed 6 years ago

BlakeGuilloud commented 6 years ago

There is an issue in our VoterLookup Modal that causes errors / info alerts to persist after the modal has been closed. This leads to an unwanted UX, as closing the modal should refresh the form.

Steps to reproduce:

After following the above steps:

image

There is an issue that goes in hand with this:

After triggering "No Voter Registration Info Found" feedback by entering a voter name that is not found. I.E. First Name: "Leslie", Last Name: "Knope", and then closing the Modal as mentioned above, the "No Voter Registration Info Found" warning will persist:

image

Acceptance Criteria

mrcolo commented 6 years ago

Hey! I can work on this!

SchaeStewart commented 6 years ago

Hey, that's awesome! Contact us on slack in the proj-govote channel, if you need any help

BlakeGuilloud commented 6 years ago

Hey @mrcolo ! Just checking in to make sure you are still interested in this issue?

mrcolo commented 6 years ago

Hey! Sorry for the lag. I've tried to edit the React components, but error still show up. I am glad somebody was able to solve the issue!

BlakeGuilloud commented 6 years ago

No problem @mrcolo ! We had our Community Action Night tonight and one of the attendees was able to solve it.

mrcolo commented 6 years ago

Maybe I should work on something a little more basic. I am familiar with React but I still have issues when it comes to very specific bugs. @BlakeGuilloud Let me know if there's anything else I can help with!