codeforgso / GoVote

Local voter registration and election candidate application.
http://govotegso.org/
GNU General Public License v3.0
24 stars 46 forks source link

Dockerfile npm install not working #69

Closed SchaeStewart closed 6 years ago

SchaeStewart commented 6 years ago

This is a:

BUG

Expected Behavior

Contributors should not have to run npm install in their dev environments on their host machines. This is handled by the GoVote docker image.

Current Behavior

If a contributor does not run npm install the node_modules directory does not get created and no packages are installed.

Possible Solution

Change Dockerfile to fix issue.

Steps to Reproduce (for bugs)

  1. rm -rf node_modules
  2. npm run docker:build && npm run docker:createTables - The createTables command will throw an error
  3. npm install on host machine
  4. npm run docker:build && npm run docker:createTables - The error is no longer thrown

Your Environment