search

codefori / vscode-ibmi

🌍 IBM i development extension for VS Code
https://codefori.github.io/docs/#/
MIT License
283 stars 93 forks source link

Deploy is not working ... #1060

Closed christianlarsen closed 1 year ago

christianlarsen commented 1 year ago

I have been trying to deploy some "old" projects using pub400.com. ... but I have been receiving an error...

This is just an example:

Current library: CLV1 Library list: CLV1 QGPL GAMES400 QTEMP Commands: /QOpenSys/pkgs/bin/gmake BIN_LIB=CLV1 OPT=*EVENTF

bsh: *CURLIB=CLV1: is not an identifier bsh: {usrprf}=CLV: is not an identifier bsh: LOCALPATH=/Users/christianlarsen/pub400/events/qrpglesrc/events01.rpgle: is not an identifier

Fetching errors from CLV1/events01.

My makefile is:

BIN_LIB=CMPSYS LIBLIST=$(BIN_LIB) CLV1 SHELL=/QOpenSys/usr/bin/qsh

all: events01.rpgle clevents01.clp

%.rpgle: system -s "CHGATR OBJ('/home/CLV/events/qrpglesrc/$.rpgle') ATR(CCSID) VALUE(1252)" liblist -a $(LIBLIST);\ system "CRTBNDRPG PGM($(BIN_LIB)/$) SRCSTMF('/home/CLV/events/qrpglesrc/$.rpgle') DBGVIEW(ALL) OPTION(EVENTF)"

%.clp: system -s "CHGATR OBJ('/home/CLV/events/qclsrc/$.clp') ATR(CCSID) VALUE(1252)" liblist -a $(LIBLIST);\ system "CRTBNDCL PGM($(BIN_LIB)/$) SRCSTMF('/home/CLV/events/qclsrc/$.clp') DBGVIEW(SOURCE) OPTION(EVENTF)"

And my actions.json. is:

[ { "name": "Build and deploy with make 🔨", "command": "/QOpenSys/pkgs/bin/gmake BIN_LIB=&CURLIB OPT=*EVENTF", "environment": "pase", "deployFirst": true, "extensions": [ "GLOBAL" ] } ]

worksofliam commented 1 year ago

Think it's got something to do with your default shell.

What is your default shell?

worksofliam commented 1 year ago

Found a possible bug.

worksofliam commented 1 year ago

Yes, there are values being passed that should not be there. Working on a fix now.

worksofliam commented 1 year ago

@christianlarsen 1.7.2 is being released which will fix your issue.

dixie-fj commented 8 months ago

@worksofliam I am having a similar issue, I am also using pub400, and @christianlarsen 's repository. My PC's default shell is bash.

Running Action: Deploy and built 🔨 (1:45:02 PM)
Working directory: /home/JONESF/test
Commands:
                /QOpenSys/pkgs/bin/gmake BIN_LIB=JONESF1 OPTS=*EVENTF

bsh: LOCALPATH=c:\Development\christianlarsen_rpgle\qrpglesrc\test11.rpgle: is not an identifier

Fetching errors for JONESF1/TEST11.

Very new to both RPG and IBM i, therefore, some direction would be much appreciated.

worksofliam commented 8 months ago

@dixie-fj I would ensure that bash is your default shell!

Right click on your connection before connection and 'connect and reload' to ensure it.

2Fast2Furichous commented 8 months ago

@worksofliam That was the solution! Thanks for the expedient help, I completely missed the notification requesting to change my bash settings. Really love the work you all have done, and look forward to seeing all the future changes!

worksofliam commented 8 months ago

@2Fast2Furichous Glad to hear it! I am going to update our docs with that info since it's missing, but also add something to the extension to tell the user automatically!