codefori / vscode-ibmi

🌍 IBM i development extension for VS Code
https://codefori.github.io/docs/#/
MIT License
280 stars 93 forks source link

Publish extension to open-vsx.org for VS Codium #126

Closed chrjorgensen closed 2 years ago

chrjorgensen commented 3 years ago

This extension is not available in the marketplace open-vsx.org used by VS Codium.

Instructions are in place on how to publish an extension to both marketplaces and can be found on the Open VSX Wiki.

It would be nice for this free extension to be available to the telemetry-free version of VS Code.

worksofliam commented 3 years ago

Cool idea. I'll get around to it sometime. In the meantime, you can still download the vsx from the Marketplace.

worksofliam commented 3 years ago

@chrjorgensen Seems like the latest version of Code for IBM i is there already.

What is the status of this?

chrjorgensen commented 3 years ago

Open VSX has an option to pull an extension into their marketplace, and I made a PR in their repository to pull this extension while waiting for you to decide whether to publish it yourself. Open VSX will also update the version periodically to the latest version.

I still prefer you to publish to both marketplaces - since the extension in Open VSX is always behind until refreshed. You can take ownership of the namespace and the extension as explained in the wiki.

However, if you do not bother and just close this issue, we'll have to live with that.

TIA.

worksofliam commented 3 years ago

@chrjorgensen Thanks for letting me know. I will leave it open and I will be sure to come around to it.

worksofliam commented 2 years ago

I just saw this commit from @barrettotte:

https://github.com/barrettotte/vscode-ibmi-languages/commit/4241547f49c82e61af53a7a1a97efaff74ab14f0#diff-7829468e86c1cc5d5133195b5cb48e1ff6c75e3e9203777f6b2e379d9e4882b3R26

It looks like we can automate the publishing.

barrettotte commented 2 years ago

@worksofliam haha yeah i hope to implement this one in vscode-ibmi-languages soon™

I had an issue with using my publisher, barrettotte, for some reason, but I'll comment back again with a commit if I manage to shake something loose. I'm sure its not complicated to figure out, but I'm kind of brain dead

chrjorgensen commented 2 years ago

@barrettotte Maybe you have to claim the namespace of your extension before publishing directly to Open VSX?

It would be great of the extensions for IBM i could be published directly to Open VSX marketplace - the refresh process of Open VSX is quite unstable and slow, so the extensions there are almost always releases behind... 👎

barrettotte commented 2 years ago

@worksofliam Just a quick heads up, I (think) I had to make a PR to Open VSX to claim my extension's namespace before publishing to both marketplaces

chrjorgensen commented 2 years ago

@worksofliam Any thoughts on publishing to the Open VSX marketplace? This could be automated after claiming the namespace for your extension as @barrettotte had to do.

It would be great to have your super extension published automatically to Open VSX - together with the additional extensions for IBM i which rely on this one. ❤️

worksofliam commented 2 years ago

@chrjorgensen - thanks for poking me again.

https://github.com/EclipseFdn/open-vsx.org/issues/813

Action has been updated, 0.8.20 will be published when it's done.

worksofliam commented 2 years ago

Looks like we're golden!

https://github.com/halcyon-tech/vscode-ibmi/runs/4862898839?check_suite_focus=true#step:7:1

chrjorgensen commented 2 years ago

Hi @worksofliam

Did you write to me about the sudden problem with publishing to Open VSX? I would swear I saw something, but I can't remember where... well, whatever.

The publish process has failed for 8 days now - which coincides with a change in the ovsx CLI tool . Could this be the cause?

I saw that your other extensions like vscode-rpgle didn't have problem publishing to Open VSX. Their ci.yaml script is a bit different and does not install the ovsx CLI tool with npm, but simply run the ovsx publish command with npx. npx downloads the ovsx CLI tool before running the publish function, so no problem here.

Hopefully my observation can help in fixing the problem publishing to ovsx...

😃