search

codefori / vscode-ibmi

🌍 IBM i development extension for VS Code
https://codefori.github.io/docs/#/
MIT License
264 stars 91 forks source link

Fix rename/move on IFS directories #2104

Closed SanjulaGanepola closed 1 day ago

SanjulaGanepola commented 3 weeks ago

Changes

Fixes #2103

How to test this PR

Examples:

  1. Run the test cases
  2. Expand view A and right click on the node
  3. Run 'Execute Thing' from the command palette

Checklist

SanjulaGanepola commented 3 weeks ago

Good idea to keep the behavior consistent between stream files and directories. Updated the PR.

sebjulliand commented 3 weeks ago

@SanjulaGanepola looks good to me! Would you be able to update your fork's master to include the new translation files and merge it into this branch?

@chrjorgensen, @marianne-ott , @NicolasSchindler can you guys add the missing translations please? 🙏🏻 Many thanks!

chrjorgensen commented 3 weeks ago

@sebjulliand Danish translation is in...

chrjorgensen commented 1 week ago

@NicolasSchindler You changed the Danish translation file instead of the German translation file in commit 3fd6f90 - could you please fix this? 😉

sebjulliand commented 1 week ago

@NicolasSchindler You changed the Danish translation file instead of the German translation file in commit 3fd6f90 - could you please fix this? 😉

This one's on me since @NicolasSchindler couldn't commit directly on this branch? I'll fix it!

SanjulaGanepola commented 1 week ago
  1. The new directory is opened as a file, causing an error message:

@chrjorgensen Thanks for catching that issue. Fixed it -> 2ec6e40

FYI, also found another issue where the mv command would fail but no error was shown if for example you tried to move a file to a directory that does not exist. Fixed this as well -> 19552a5

worksofliam commented 1 day ago

@SanjulaGanepola Please update the 'How to test' in the PR.

worksofliam commented 1 day ago

@SanjulaGanepola 'Move/Rename...' works as expected. Do let me know if there is more than needs testing.

SanjulaGanepola commented 1 day ago

@SanjulaGanepola 'Move/Rename...' works as expected. Do let me know if there is more than needs testing.

@worksofliam Sorry for the late reply. I see this was already merged, but yes only "Move/Rename" needed to be tested on directories