search

codefori / vscode-ibmi

🌍 IBM i development extension for VS Code
https://codefori.github.io/docs/#/
MIT License
288 stars 96 forks source link

Can't open source members with the symbol '§' in the name #719

Closed mprovvedi closed 2 years ago

mprovvedi commented 2 years ago

Can't open source members with symbol '§' in the name, this issue occurred since release 1.3.4 Same issue as: https://github.com/halcyon-tech/vscode-ibmi/issues/701

worksofliam commented 2 years ago

@alfax218 are you suggesting you were able to open up those members in 1.3.7? You should downgrade for the time being if that's the case.

worksofliam commented 2 years ago

@p-behr check this out.

mprovvedi commented 2 years ago

@alfax218 are you suggesting you were able to open up those members in 1.3.7? You should downgrade for the time being if that's the case.

I can open those members only if i downgrade to 1.3.3

worksofliam commented 2 years ago

@alfax218 we know the issue. A fix will be out sometime today.

worksofliam commented 2 years ago

@alfax218 1.3.9 with this fix is deploying now. Thanks @p-behr !

mprovvedi commented 2 years ago

Problem fixed! Keep going, you're doing a great job!

worksofliam commented 2 years ago

@chrjorgensen Take a look at this issue. I know we're looking at CCSID issues, but isn't it hilarious that member names can have this character in them?

chrjorgensen commented 2 years ago

@worksofliam This is indeed also a CCSID issue - the CCSID 37 US characters '#@$' becomes '£§$' in CCSID 280 ITA. I guess an Italian will maybe not use any of the characters '£§$' in a member name, but if the member is installed or restored from an external (american) party, these characters may get used anyway.

This is exactly the kind of problem, that my PR #714 will fix - no more need for adding special characters to the regexp for system names... 😃