codefori / vscode-ibmi

🌍 IBM i development extension for VS Code
https://codefori.github.io/docs/#/
MIT License
288 stars 95 forks source link

Compile error markers no longer appear #849

Closed m-tyler closed 2 years ago

m-tyler commented 2 years ago

After updating to 1.5.9 or 1.5.10 I no longer get embedded compile errors markers in the source. I have to search through the IBM I Output view to see what the issue is. The main issue I have with doing this is the tool will reload information for the open member into that output view and cause the view to scroll. If I don't clear the view before compiling and I don't open the source listing right away I have to clear and recompile.

Is there a new setting I'm not seeing?

Variants

{
  "american": "%23@$",
  "local": "%23@$"
}

Notice the red outlined source quick view does not show the red marker. image

worksofliam commented 2 years ago

After you run an Action, scroll to the bottom of IBM i Output below the spool file. You should see a message about *EVENTF. What does it say?

worksofliam commented 2 years ago

It should either say:

Fetching errors from XX/XX.

Or

*EVENTF not found in command string. Not fetching errors from XX/XX.

m-tyler commented 2 years ago

image

worksofliam commented 2 years ago

Ok. After trying a compile, please paste the output from the Code for IBM i output channel here.

m-tyler commented 2 years ago

Code for IBMi - output channel.txt

worksofliam commented 2 years ago

Ok. I can see the command being executed to grab the file.

QSYS/CPYTOIMPF FROMFILE(PGXX/EVFEVENT TESTPRPSP5) TOSTMF('/home/PGXX/tmp/vscodetemp-O_BS3aQhJd') MBROPT(*REPLACE) STMFCCSID(1208) RCDDLM(*CRLF) DTAFMT(*DLM) RMVBLANK(*TRAILING) ADDCOLNAM(*SQL) FLDDLM(',') DECPNT(*PERIOD)

Any chance you can grab this member for me? You should run that command yourself to a different streamfile and upload it here.

worksofliam commented 2 years ago

Also, can you confirm that PGXX from FROMFILE(PGXX/EVFEVENT TESTPRPSP5) is the same library you're compiling the object in?

m-tyler commented 2 years ago

Okay, I'm sorry for wasting your time. I did not notice that the tool was using the default CPYTOIMPF command instead of the one my company has me use (as we have not migrated off the old 5.1 version of the command yet). The default command you supply causes the data in the tmp/folder to be code page 37 instead of 1208.

This is the reason I asked for a change in #493.

Thanks for the assist showing me I forgot to make a change to the tool.