Feature/rename_provider

[worksofliam]

Changes

Initial work to start refactoring for RPG (**free only)

• Implements rename provider for RPGLE.
• New cache API for getting definition based on offset (internal).
• Fixes bug where parameter names were not shown when writing code inside of procedure.
• Adds new internal rule to be able to run Embedded SQL statements in the Db2 for i extension.
• StringLiteralDupe no longer shown as warning, but instead shown under the Refactor option.

Todo

• [x] Fix tests for CollectReferences change
• [x] Implement the rename provider
• [x] Ensure that subfields can be renamed
• [x] Ensure that go to definition continues to work for fixed format.
• [x] Merge #265

Checklist

• [x] have tested my change
• [ ] updated relevant documentation
• [ ] Remove any/all console.logs I added
• [ ] eslint is not complaining
• [ ] have added myself to the contributors' list in the README
• [ ] for feature PRs: PR only includes one feature enhancement.

[worksofliam]

Depends on #265 for cache.ts rewrite (js -> ts).

[worksofliam]

@chrjorgensen You are amazing for your review. I missed a whole bunch of logic for definition subfield references and now it is solved (with test cases!). Thanks for your example, which I went ahead and borrowed as you will see in the commit.

Please try again and let me know what you think.

[chrjorgensen]

@worksofliam I just did some new tests:

• rename standalone constant declaration - OK
• rename referenced standalone constant in assignment - OK
• rename variable in declaration - OK
• rename variable in assignment - OK
• rename DS subfield - OK now! 👍
• rename referenced DS subfield - OK now! 👍
• rename constant declaration in enumeration - failed:
• rename referenced constant enumeration to completely new name - failed:
• rename referenced constant enumeration to name with appended chars - failed:

And the spelling mistake refereneceByOffset has not yet been fixed...

[worksofliam]

@chrjorgensen Errors solved and spelling fixed!

[chrjorgensen]

@worksofliam

@chrjorgensen Errors solved and spelling fixed!

Did you miss something? I get the following errors now when typing F2:

[worksofliam]

@chrjorgensen I am sorry. I didn't do a push 🙄 Try again!

[chrjorgensen]

@worksofliam Approved - merge whenever you feel for it! 😃