search

codeforkansascity / meep

Mapping Energy Efficiency & Public Health
MIT License
10 stars 20 forks source link

Change default argument of create_app to a string #20

Closed galbwe closed 5 years ago

galbwe commented 5 years ago

Thanks to Adam Mertz for pointing this out.

As explained in this article, using a mutable type as a default argument to a python method can result in unexpected behavior if the object state changes during runtime. Accordingly, we should change create_app to accept string arguments which map to config classes via a dictionary.

galbwe commented 5 years ago

Backend issues are moving to the meep backend repo