codeforkjeff / dbt-sqlite

A SQLite adapter plugin for dbt (data build tool)
Apache License 2.0
78 stars 13 forks source link

upgrade to support dbt-core v1.2.0 #21

Closed dataders closed 1 year ago

dataders commented 2 years ago

We've just published the release cut of dbt-core 1.2.0, dbt-core 1.2.0rc1 (PyPI | GitHub release notes).

https://github.com/dbt-labs/dbt-core/discussions/5468 is an open discussion with more detailed information, and https://github.com/dbt-labs/dbt-core/issues/5474 is for keeping track of the communities progress on releasing 1.2.0

Below is a checklist of work that would enable a successful 1.2.0 release of your adapter.

https://github.com/dbt-labs/dbt-core/pull/5432 might make it into the second release cut in the next week, in which case, you'll also might want to:

codeforkjeff commented 2 years ago

Here's a branch with some WIP. Time is scarce for me at the moment, so it may take me a while to work through the failing cross-db macro tests. If anyone wants to help, they're welcome to submit PRs into that branch! 😅

https://github.com/codeforkjeff/dbt-sqlite/pull/24

cboden commented 1 year ago

Looks like there have been two RC releases. Can a final version of v1.2.0 be tagged?

codeforkjeff commented 1 year ago

I haven't worked on this in a few months, but I think there's two areas remaining to be done:

The latest 1.2.0a3 release should be working in a basic way with dbt-core 1.2.x but it'd be good to resolve these before a final release.

Anyone is welcome to help if they have the time, energy, and know-how!

codeforkjeff commented 1 year ago

I think I got a handle on the type issues (see #36).

I may just give up on those macros and do a 1.2.0 release. The date-related ones are of somewhat limited use because date types aren't enforced in SQLite anyway.