search

codeforkjeff / dbt-sqlite

A SQLite adapter plugin for dbt (data build tool)
Apache License 2.0
78 stars 13 forks source link

Update connections.py for the unique_field property #49

Closed zxiex closed 7 months ago

tom-juntunen commented 7 months ago

~LGTM!~

There are other PRs that address this more purposefully.

tom-juntunen commented 7 months ago

Now that I've been invited to contribute to this repository, I care more about the quality of the fix to this problem than I did 3 days ago when I was just trying to get past the blocker while using the package for the first time.

There is an alternative approach mentioned here: https://github.com/codeforkjeff/dbt-sqlite/pull/51/files#r1572961960

This is more in-line with the intention of the unique_key method and what its documentation states it does.

tom-juntunen commented 7 months ago

Closing this PR as this other PR was merged that fixes this problem per comment above. https://github.com/codeforkjeff/dbt-sqlite/pull/51