add minimum compatibility for 1.6.0 - Githubissues

codeforkjeff / dbt-sqlite

A SQLite adapter plugin for dbt (data build tool)

Apache License 2.0

78 stars 13 forks source link

add minimum compatibility for 1.6.0 #55

Open tom-juntunen opened 7 months ago

tom-juntunen commented 7 months ago

Per the adapter maintainer upgrade guide for v1.6.0, this PR includes the following:

Bugs fixed:

Fixed a bug causing the dateadd macro to fail its tests when handling DATETIME type fields. The updated sqlite__dateadd.sql macro now adequately handles both DATE and DATETIME types per ISO-8601 and passes its tests now.

Changes made:

[BtS] Adapter zone tests

Added four new tests in test_utils.py and all tests passed without overrides.

No changes required:

[BtS] Drop support for Py 3.7

Support for Py 3.7 was already removed in dbt-sqlite 1.2.0rc1.

[BtS] new arg for adapter.execute()

We use SQLConnectionManager.execute() directly. No changes required.

No changes made:

[FEATURE] Materialized Views:

Materialized views are not supported in sqlite3. No changes made.

[FEATURE] dbt clone

Clone objects are not supported in sqlite3 because it is a simple in-process database.

[BtS] revamp of dbt debug

No new warnings or errors in tests. No changes made.

Possible remaining todo:

Left out tests related to Contracts as they aren't being implemented as a feature. I had created a test and ran it only to see the test failed, which was expected, so the unit test needs to be overridden in order to make that passing criteria instead of failing.

codeforkjeff commented 7 months ago

This is fantastic! Everything looks really good here and ready to merge.

kokorin commented 4 months ago

@codeforkjeff do you think we can expect this PR merged and new version released to PyPI?