search

codeformilwaukee / DECARCERATION-PLATFORM

https://wisdp.com
GNU General Public License v3.0
18 stars 17 forks source link

add external links to home page #48

Closed hdenisenko closed 4 years ago

hdenisenko commented 4 years ago

addressing this issue

Not going off any design specs (should i be??), so just did the best I could think of without knowing the final look of the page. Happy to make whatever edits are suggested!

paul-rinaldi commented 4 years ago

This is great, I added one change for readability. Please like this comments if you agree with my last commit, @hdenisenko then I'll close!

hdenisenko commented 4 years ago

@paul-rinaldi i don't see your change - i only see my commit here. but whatever your change is, i'm sure it's great! let me know whatever next steps i can start for this pr to go through.

paul-rinaldi commented 4 years ago

@hdenisenko I can't seem to push to your fork... I must have gotten something wrong. I reviewed the PR and left a comment, that's all. Thanks!

... fatal remote errors and it's a simple change paulrinaldi@.../DECARCERATION-PLATFORM/web-app$ git push hdenisenko externalLinks fatal: remote error: You can't push to git://github.com/hdenisenko/DECARCERATION-PLATFORM.git Use https://github.com/hdenisenko/DECARCERATION-PLATFORM.git paulrinaldi@.../DECARCERATION-PLATFORM/web-app$

hdenisenko commented 4 years ago

@paul-rinaldi made the updates but looks like i'm still failing some jobs? not sure why? was another pr supposed to have addressed that or should investigate it on my end?