search

codeformilwaukee / DECARCERATION-PLATFORM

https://wisdp.com
GNU General Public License v3.0
18 stars 17 forks source link

Alt text isn't being used correctly #77

Closed hdenisenko closed 4 years ago

hdenisenko commented 4 years ago

I noticed some alt text on images describing what the image is rather than conveying the information that the image conveys to someone who can see the image (https://moz.com/learn/seo/alt-text#:~:text=Alt%20text%20is%20a%20tenet,to%20visually%20identify%20an%20image.) ex: alt="People protesting icon"

Nothing is broken right now, but fixing this would improve SEO outcomes and would make the site more accessible!

github-actions[bot] commented 4 years ago

Welcome! Thank you for your help in solving mass incarceration problems!' first issue

ValeriKozarev commented 4 years ago

Hi! I'm interested in getting involved and figured I can take this issue. Besides the three icons on the home screen, I didn't find any other images that would need changing. For reference I looked through all the directories at web-app/src/components, let me know if I should be looking elsewhere. Thanks!

paul-rinaldi commented 4 years ago

Hi! I'm interested in getting involved and figured I can take this issue. Besides the three icons on the home screen, I didn't find any other images that would need changing. For reference I looked through all the directories at web-app/src/components, let me know if I should be looking elsewhere. Thanks!

Hi @valerikozarev, I think there are 4; the hamburger button on mobile (on the home screen as well) might count as an icon... needing an alt tag. @hdenisenko , does that sound right ^

hdenisenko commented 4 years ago

i'm not seeing hamburger bar in the codebase? is it an icon defined in a component or is it a stand-alone component?