search

codeformilwaukee / DECARCERATION-PLATFORM

https://wisdp.com
GNU General Public License v3.0
18 stars 17 forks source link

updating icon alt text to be more descriptive #79

Closed ValeriKozarev closed 4 years ago

ValeriKozarev commented 4 years ago

Resolves Issue #77

I used the following website to try and come up with a better alt text for each of the icons: https://support.siteimprove.com/hc/en-gb/articles/115000013031-Accessibility-Image-Alt-text-best-practices

In regards to the burger button that appears for mobile users and small viewports, I think we can leave it alone because its a nav element. My understanding from this article (https://www.a11ymatters.com/pattern/mobile-nav/) is that as long as its treated as a nav element it will provide the clarity that is expected for screen readers.

100% open to requests for changes and advice, I want to learn about and support accessibility as much as possible!

hdenisenko commented 4 years ago

I'm just snooping, but these changes look 👍 to me!

paul-rinaldi commented 4 years ago

Not what I was expecting accessibility to be - as in, accessible actually means descriptive of action not necessarily descriptive of an image so that it's helpful! ("functional images")

we're all learning :D