search

codeformilwaukee / DECARCERATION-PLATFORM

https://wisdp.com
GNU General Public License v3.0
18 stars 17 forks source link

Separate Pages from Components #81

Open paul-rinaldi opened 4 years ago

paul-rinaldi commented 4 years ago

Is your feature request related to a problem? Please describe. Currently, there are pages and components in the same folder called components, it's not easy to navigate by a pogrammer.

Describe the solution you'd like /src/components/ (components folder) /src/pages/ (pages folders)

hdenisenko commented 4 years ago

Quick question about this - does this mean for something like /src/components/CalendarPage you want it split into /src/page/CalendarPage/index.js and the modal components in the components folder?

Caryyon commented 4 years ago

it sounds like you want /pages to be a place for actual routing && /components to be components that can be used within those pages. this can help with confusion of where is the page implemented and where is what it's built out of. is this going to mess things up for everyone else's branch at this point?

hdenisenko commented 4 years ago

that's a good question - there'll probably be a fair amount of merge conflicts. @Caryyon @paul-rinaldi is this a change we want to introduce while others are working on other branches?

Caryyon commented 4 years ago

it's very similar to how Next.js handles the matter. pages = pages components = small chunks of functionality.

paul-rinaldi commented 4 years ago

Yes @Caryyon has it right, this should be done later, I'm making more relevant issues soon (tech debt like this isn't too bad at all)