search

codeformuenster / muenster-dashboard

Eine "Stadtviertel-App", zeigt Infos aus Deiner Umgebung an, aus Open Data Datensätzen der Stadt Münster.
https://mein-ms.de/
Apache License 2.0
7 stars 4 forks source link

From ts to js #81

Closed u-rogel closed 5 years ago

u-rogel commented 5 years ago

A few major changes on this branch:

  1. Since it seems like no one wants to deal with TS I converted all files to JS.
  2. package.json was updated to latest react version.
  3. ESLint was added as well, in order to force better JS coding style.
  4. Many cosmetics were done to meet the modern react project structure.
tomsrocket commented 5 years ago

I got google security warnings on my Google account because there is a Google API key in the Sourcecode.. However, it looks like that key has always been there.. ¯_(ツ)_/¯

u-rogel commented 5 years ago

I don't see any Google API Key in the code, and I haven't added or used any as far as I know. Do you see it in the pull request as well? I will resolve the conflict and push again.

Sijoma commented 5 years ago

This is sad :(. TypeScript is awesome!

u-rogel commented 5 years ago

Are you guys still working often on the frontend of this app?

ubergesundheit commented 5 years ago

I guess no one is really working actively on this right now, so for me this is awesome!

I didn't had time to look at every change but I guess it should be mostly changes done by eslint?

One thing does not work on the deploy preview https://deploy-preview-81--mein-ms.netlify.com -> Loading Data :D