codefornola / nola-transit-map

Realtime view of all NOLA public transit vehicles https://nolatransit.fly.dev/
MIT License
21 stars 7 forks source link

Extra build dependencies #3

Closed wwkeyboard closed 2 years ago

wwkeyboard commented 2 years ago

Adds a .tool-versions with the latest nodejs and golang versions as well as calls npm install in the makefile.

nihonjinrxs commented 2 years ago

@bhelx happy to review/shepherd this PR to main, but wanted to check with you about the .tool-versions and whether there are specific versions we should be matching to the deploy environment.

bhelx commented 2 years ago

I will check

bhelx commented 2 years ago

NPM is not used in production. I couldn't tell you the minimum version.

For go, we're using the golang buildpack: https://github.com/paketo-buildpacks/go

I believe it pulls the latest version. I'm also not sure what the minimum version would be.

bhelx commented 2 years ago

These versions look good though