search

codeforokc / openbudgetokc

Visualizations of OKC's budget data, and explanations about the budget process.
https://openbudgetokc.com
12 stars 42 forks source link

issue: 91 right align the budget-tree-map and sort it alphabetically #96

Closed dashcraft closed 7 years ago

dashcraft commented 7 years ago

Changed the CSS to right align the table header and table data cells. Added some margin for readability, expanded the table for visual consistency when right aligned.

Changed the sort on the data from being the expense column greatest to least amount, to alphabetically via the item column.

resolve #91

smurphy8 commented 7 years ago

Could you throw in a screen shot please?

dashcraft commented 7 years ago

Sorry about that, i had posted the images on the slack channel...

The first image is the right aligned table (and headers) the second image is right aligned and alphabetically organized as opposed to ordered by decreasing budget $$.

right_align_budget right_align_sorted_budget

smurphy8 commented 7 years ago

Hmm, I pulled your commit and ran it but the alignment looked different for me. I tried it in Chrome version 55.0.2883.87 (64-bit) And firefox 51.0a2 (2016-10-17) (64-bit)

I also tried it in responsive mode which did look great!

What browser is that screen shot from? Here is what I saw: tablealignmentproblem

dashcraft commented 7 years ago

firefox, let me check it for compatability across browsers real quick and also across a wide screen, my screen i tested on was only 1094px , i guess i could've done that before pushing! :)

dashcraft commented 7 years ago

There, the issue was that the data table isn't reposive above 1140px, so i had to set a max width for the table to 1140px. Tested on firefox and latest chrome, no issues.

Let me know if there is anything else!

mkchandler commented 7 years ago

@dashcraft @smurphy8 My only concern about this change was that I think only the number values were supposed to be right aligned.

smurphy8 commented 7 years ago

That makes sense ...

On Jan 11, 2017 9:15 PM, "Matt Chandler" notifications@github.com wrote:

@dashcraft https://github.com/dashcraft @smurphy8 https://github.com/smurphy8 My only concern about this change was that I think only the number values were supposed to be right aligned.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/codeforokc/openbudgetokc/pull/96#issuecomment-272056780, or mute the thread https://github.com/notifications/unsubscribe-auth/AALJjPu7VgO3n2Akc0XYoqdkSNaPefDxks5rRYyqgaJpZM4LYo3I .