search

codeforokc / school-finder

Geolocation-based web app for locating schools and school districts near you
MIT License
18 stars 17 forks source link

Convert data ingest to make schools be points #8

Closed joekarl closed 9 years ago

joekarl commented 9 years ago

Polygons for school data is overkill. Change to be points.

joekarl commented 9 years ago

As per suggestion from @jvrousseau we probably only need point data for schools.

mkchandler commented 9 years ago

I agree with this. I don't see a reason why we need the polygons.

joekarl commented 9 years ago

Hmm... something we'll need to take a look at, but I'm not super happy with the results of turning the school data into points. I took the polygon information and figured out the center point of the bounding box for each school. Unfortunately, that's not necessarily where the school is actually at (a lot of schools have more land around their buildings). Also some schools are actually multipolygons and the point can end up in weird spots between the multiple polygons.

As an example, check out the Piedmont schools (the ones furthest northeast on the map). They have large land areas and the point (while the center of the school land area) doesn't correspond with the school buildings which looks like bad data on a map. https://github.com/codeforokc/school-finder/blob/schools_as_points/data_ingest_node/data/schoolPoints.topojson

joekarl commented 9 years ago

Closing this in favor of topojson polygons (added in #11)