Issue 382/refactor container creation

codeforpdx / PASS

PASS project - with HMIS module integration

MIT License

28 stars 25 forks source link

Issue 382/refactor container creation #384

Closed leekahung closed 1 year ago

leekahung commented 1 year ago

Refactor Container Creation Functions

This PR:

1. Refactors functions for container creation in src/utils/pod-management/pod-helper.js into one general function called createPASSContainer 2. Removes unused functions from User.js and SignedInUserContext.jsx 3. Updates unit tests related to these files

The files this PR effects:

Tests

test/model-helpers/User.test.js
test/utils/pod-helper.test.js

Other Files

src/contexts/MessageContext.jsx
src/contexts/SignedInUserContext.jsx
src/model-helpers/User.js
src/utils/pod-management/pod-helper.js
src/utils/index.js

xscottxbrownx commented 1 year ago

This looks good to me, but to further my understanding...

Do these containers for Inbox, Outbox, or Documents live within a PASS folder/container to begin with? Like if user goes to some solid gui will they see a PASS folder and everything is housed inside that?

leekahung commented 1 year ago

This looks good to me, but to further my understanding...

Do these containers for Inbox, Outbox, or Documents live within a PASS folder/container to begin with? Like if user goes to some solid gui will they see a PASS folder and everything is housed inside that?

Yeah that is correct, all these containers are containers within a container called PASS.

leekahung commented 1 year ago

I like this overall. I think it's good

Is this ready for merging or there's still some things you think we should still do here?