Closed leekahung closed 1 year ago
This looks good to me, but to further my understanding...
Do these containers for Inbox
, Outbox
, or Documents
live within a PASS folder/container to begin with? Like if user goes to some solid gui will they see a PASS folder and everything is housed inside that?
This looks good to me, but to further my understanding...
Do these containers for
Inbox
,Outbox
, orDocuments
live within a PASS folder/container to begin with? Like if user goes to some solid gui will they see a PASS folder and everything is housed inside that?
Yeah that is correct, all these containers are containers within a container called PASS.
I like this overall. I think it's good
Is this ready for merging or there's still some things you think we should still do here?
Refactor Container Creation Functions
This PR:
1. Refactors functions for container creation in
src/utils/pod-management/pod-helper.js
into one general function calledcreatePASSContainer
2. Removes unused functions fromUser.js
andSignedInUserContext.jsx
3. Updates unit tests related to these filesThe files this PR effects:
Tests
test/model-helpers/User.test.js
test/utils/pod-helper.test.js
Other Files
src/contexts/MessageContext.jsx
src/contexts/SignedInUserContext.jsx
src/model-helpers/User.js
src/utils/pod-management/pod-helper.js
src/utils/index.js