search

codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
28 stars 25 forks source link

Dockerfile.react created, docker-compose.yaml #391

Closed Fokker50 closed 12 months ago

Fokker50 commented 1 year ago

name: Pull Request about: Create a pull request to merge your code into the PASS codebase title: 'Enhance Docker Setup and NGINX Configuration' labels: enhancement, docker assignees: Nurbol

Enhance Docker Setup and NGINX Configuration

This PR:

1. Updates the Dockerfile for the React app (Dockerfile.react). 2. Enhances the docker-compose.yaml to orchestrate services it start react-app and solid-server . 3. Modifies NGINX configuration, although it still needs further configuration , I commented out reverse proxy in docker-compose .

The files this PR affects:

Components

Tests

No test files are affected.

Other Files

No other files are affected.

Screenshots (if applicable):

N/A

Additional Context (optional):

I've been making progress on refining the Docker setup for our project. Currently, the Dockerfile for the app image is working well, and the docker-compose.yaml has been set up to orchestrate services. However, the configuration for the Solid Community Server within the NGINX setup still requires attention.

Future Steps/PRs Needed to Finish This Work (optional):

The focus now is on configuring the Solid Community Server to work seamlessly within the Docker environment. Once that is done, I'll finalize the NGINX configuration to serve the React app properly.

Issues needing discussion/feedback (optional):

Details about Simplified Settings:

In response to feedback, I have simplified the settings related to reverse proxy in the Docker Compose file. Certain parts have been commented out. This decision was made to streamline the setup and address performance concerns. Your feedback on this approach would be highly valuable.

xscottxbrownx commented 1 year ago

Is this for Issue #375 ?

Fokker50 commented 1 year ago

Is this for Issue #375 ?

Yes it is, my bad:)