search

codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
28 stars 25 forks source link

Bug fix for contacts page #394

Closed leekahung closed 1 year ago

leekahung commented 1 year ago

Bug Fix for Contacts Page

This PR:

1. Fixes the bug where the website fails to render after login due to undefined variable client by changing it to contact and modifying the area which are causing the issue 2. Also removes the unused link element from index.html for the original css file

The files this PR effects:

Components/Pages

Other Files

Screenshots (if applicable):

Screenshot of fix:

https://github.com/codeforpdx/PASS/assets/14917816/1de0d2d0-ed42-4b28-9064-07f69719033d

Screenshot of signup link rendering for signups page:

https://github.com/codeforpdx/PASS/assets/14917816/1c51add1-2782-4773-94ea-bdc8d7cc2a20

leekahung commented 1 year ago

Good quick fix

Only question is whether client should also be changed to contact on lines 45 and 111

Yeah, I think I could do that before merging in the fixes. I'll check any of the test files, too, in case it fails one of them.

leekahung commented 1 year ago

Hey @xscottxbrownx and @timbot1789, I've just updated PR based on the new comments. Let me know if there's still anything else that would need to be corrected. Would like to merge this in as soon as possible to fix the existing rendering bug.