Closed Raspber closed 11 months ago
See comment
Will get this sorted 👍🏽
Overall good changes.
1) There's an issue with the icon spacing if you resize browser. 2) I would say go ahead and change the other footer file as well to make the copyright
CODE PDX
(dropping the "for" as we are rebranding, and all caps.)
Will get this sorted out today.
Hey @Raspber. What is the progress of this? I see that Scott pointed out some thing that needs to be addressed.
Hey @Raspber. What is the progress of this? I see that Scott pointed out some thing that needs to be addressed.
Working on this as well
Since we're transitioning the organization name from Code for PDX to CODE PDX, we'll eventually need to update this again with the new branding. However, for this PR I think it's fine as is since we're not entirely sure when that whole process will be complete.
Nice 👍
Like @xscottxbrownx said, the social icons get pretty crowded right before the breakpoint for mobile (just over ~600px viewport). I recommend we merge as is.
There will be more work on the footer with the forthcoming updates from the UI team.
name: Pull Request about: Create a pull request to merge your code into the PASS codebase title: 'Enhance: app footer' labels: 'enhancement, footer' assignees: 'Raspber'
Enhance App Footer
This PR:
1. Updated "proposal" button to a call to action in the RenderCallToActionSection.jsx 2. Updated Twitter icon to the newest X icon. 3. Removed unnecessary items within the RenderCompanyInfoSection.jsx, such as the codepdx logo with the tagline, and the built by.
The files this PR effects:
Components
Tests
No test files are affected
Other Files
No other files are affected
Screenshots (if applicable):
No update![footer-no-update](https://github.com/codeforpdx/PASS/assets/20136800/9936f001-6efa-455b-84cc-71647d23ea21)
Updated![footer-updated](https://github.com/codeforpdx/PASS/assets/20136800/fecc2a1f-44a7-4098-8f51-7f75b08f0ccd)
Additional Context (optional):
Will be creating a new issue to create new pages/routes for the terms and conditions link.
Future Steps/PRs Needed to Finish This Work (optional):
Issues needing discussion/feedback (optional):