search

codeforpdx / PASS

PASS project - with HMIS module integration
MIT License
26 stars 25 forks source link

Add Contact - changing client terminology to contact #426

Closed xscottxbrownx closed 10 months ago

xscottxbrownx commented 10 months ago

Add Contact "client" --> "contact"

This PR:

Resolves #425

1. Changes confirm button to ADD CONTACT 2. Changes success notification to ...added to contact list

The files this PR effects:

Components

AddContactModal.jsx

Tests

List file names here

Other Files

List file names here

Screenshots (if applicable):

Screenshot 2023-09-14 at 9 25 16 PM Screenshot 2023-09-14 at 9 25 34 PM
andycwilliams commented 10 months ago

Putting 'client' in search for the whole repo yields a lot of results. Will be want to change every instance of it, and if so, will we want it in the scope of this PR?

If not, this should be good to go.

leekahung commented 10 months ago

Putting 'client' in search for the whole repo yields a lot of results. Will be want to change every instance of it, and if so, will we want it in the scope of this PR?

That would not be a good idea. For example, React Query utilizes a parameter called client that's not related to the PASS client. We could do this correction on a case-by-case basis.

xscottxbrownx commented 10 months ago

I could change the name of the issue and this PR to more directly reference the ADD CONTACT modal, if we'd like.

xscottxbrownx commented 10 months ago

I could change the name of the issue and this PR to more directly reference the ADD CONTACT modal, if we'd like.

Oh I guess I did on the Issue, so I'll change it here.